Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG - WIP] Add tests showing a reprojection bug in the GeometryFileSource #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caspervdw
Copy link
Collaborator

@caspervdw caspervdw commented Dec 12, 2019

This seems to have to do with the presence of "no_defs": True in the CRS that is generated here:

crs = utils.get_crs(request["projection"])

@caspervdw
Copy link
Collaborator Author

How can tests pass? Locally they do not!

@caspervdw caspervdw changed the title Add tests showing a reprojection bug in the GeometryFileSource [BUG - WIP] Add tests showing a reprojection bug in the GeometryFileSource Dec 12, 2019
@caspervdw
Copy link
Collaborator Author

Discussed offline:

  • It is only occuring with pyproj >= 2
  • it has to do with the presence of "no_defs" in the fiona-generated EPSG CRS

Related to:
geopandas/geopandas#990

@caspervdw caspervdw added the bug Something isn't working label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant