Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[water-quality] Add substance concentrations to timeseries plotter #1001

Merged
merged 8 commits into from
May 30, 2024

Conversation

hoanphungt
Copy link
Contributor

No description provided.

@hoanphungt hoanphungt changed the base branch from master to refactor May 27, 2024 12:53
@hoanphungt hoanphungt requested review from benvanbasten-ns and arjanverkerk and removed request for benvanbasten-ns May 28, 2024 10:27
Copy link
Contributor

@arjanverkerk arjanverkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I'd like to see to comments in the code clarified / extended. And I have one question that I'd like an answer to.

datasource/threedi_results.py Outdated Show resolved Hide resolved
datasource/threedi_results.py Show resolved Hide resolved
datasource/threedi_results.py Outdated Show resolved Hide resolved
@hoanphungt hoanphungt merged commit dc16658 into refactor May 30, 2024
1 check passed
@hoanphungt hoanphungt deleted the hoan-water-quality-results-timeseries branch May 30, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants