Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pumps in result aggregation tool #1014

Merged
merged 32 commits into from
Sep 9, 2024

Conversation

leendertvanwolfswinkel
Copy link
Collaborator

No description provided.

raster_layer = QgsRasterLayer(raster_output_fn, layer_name if layer_name else f"Aggregation results: raster {rastname}")
raster_layer = QgsRasterLayer(
raster_output_fn,
layer_name or f"Aggregation results: raster {rastname}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

koning

)
style.apply(qgis_layer=qgs_lyr, style_kwargs=style_kwargs)
# vector layers
for output_layer_name, layer_name_widget, style_type_widget in [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@benvanbasten-ns benvanbasten-ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not overly familiar with the result aggregation tool, but this seems fine

Base automatically changed from refactor to master July 18, 2024 09:39
- Add pump support to Result Aggregation tool
- Add preset "Total pumped volume" to Result Aggregation tool
- Add preset "Pumps: % of time at max capacity" to Result Aggregation tool
- Cross-sectional discharge algorithm: allow cross-section lines to have different crs than 3Di results, automatically reproject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better do this in another PR next time, keep them as lean as possible

Copy link
Contributor

@benvanbasten-ns benvanbasten-ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks okay, but the PR is too big for me to fully comprehend what's going on whether it will work. Better test it properly.

@leendertvanwolfswinkel leendertvanwolfswinkel merged commit 5c77ea5 into master Sep 9, 2024
1 check passed
@leendertvanwolfswinkel leendertvanwolfswinkel deleted the leendert-pumps-in-result-aggregation branch September 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants