-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pumps in result aggregation tool #1014
Add support for pumps in result aggregation tool #1014
Conversation
tool_statistics/statistics.py
Outdated
raster_layer = QgsRasterLayer(raster_output_fn, layer_name if layer_name else f"Aggregation results: raster {rastname}") | ||
raster_layer = QgsRasterLayer( | ||
raster_output_fn, | ||
layer_name or f"Aggregation results: raster {rastname}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
koning
tool_statistics/statistics.py
Outdated
) | ||
style.apply(qgis_layer=qgs_lyr, style_kwargs=style_kwargs) | ||
# vector layers | ||
for output_layer_name, layer_name_widget, style_type_widget in [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not overly familiar with the result aggregation tool, but this seems fine
Choose threshold attribute
Leendert pumps presets
- Add pump support to Result Aggregation tool | ||
- Add preset "Total pumped volume" to Result Aggregation tool | ||
- Add preset "Pumps: % of time at max capacity" to Result Aggregation tool | ||
- Cross-sectional discharge algorithm: allow cross-section lines to have different crs than 3Di results, automatically reproject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better do this in another PR next time, keep them as lean as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay, but the PR is too big for me to fully comprehend what's going on whether it will work. Better test it properly.
No description provided.