Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to cross sectional discharge processing algorithm #927

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

leendertvanwolfswinkel
Copy link
Collaborator

@leendertvanwolfswinkel leendertvanwolfswinkel commented Oct 11, 2023

Some changes were needed after the changes to threedigrid_ogr.py

Note: kcu_description was removed; instead, the line_type is used in a value map in the styling, to provide the appropriate kcu (line type) descriptions to users

@leendertvanwolfswinkel leendertvanwolfswinkel changed the base branch from master to refactor October 11, 2023 15:20
Copy link
Contributor

@benvanbasten-ns benvanbasten-ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems appropriate replacements, except kcu_description and line_type are not the same data

@benvanbasten-ns benvanbasten-ns merged commit 83d15fd into refactor Oct 18, 2023
1 check passed
@benvanbasten-ns benvanbasten-ns deleted the leendert-fix-cross-sectional-discharge branch October 18, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants