-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproject schematisation #160
Open
margrietpalm
wants to merge
98
commits into
master
Choose a base branch
from
margriet_111_reproject_schematisation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght float instead of text
…use temporary spatialite instead
* Add removing of views and combine implementation with removing triggers
…ect_schematisation
…ect_schematisation
…ns/threedi-schema into margriet_111_reproject_schematisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate schema such that all geometries in the schematisation have the model CRS. Migrations without epsg_code are not permitted and will raise. To allow for migrations of empty schematisations, as used in tests,
custom_epsg_code
is added as an argument to the upgrade function.Added properties to retrieve the epsg_code and source object of that code from the schematisation (used by modelchecker and grid-builder).
To properly set all spatial indices the following is necessary
Unfortunately, this triggers a bunch of warnings:
I played around with the
RecoverGeometryColumn
,CreateSpatialIndex
andRecoverSpatialIndex
but I could not find a combination or order that resulted in valid spatial indices without these warnings. A fresh pair of eyes is highly appreciated.Note: this will eventually be merged on master, but current work is based on schema leftovers that will be merged with master before this one