Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to dotnet 9 #1257

Merged
merged 20 commits into from
Jan 22, 2025
Merged

update to dotnet 9 #1257

merged 20 commits into from
Jan 22, 2025

Conversation

chenzhitong
Copy link
Member

No description provided.

@shargon
Copy link
Member

shargon commented Nov 28, 2024

It's better to avoid the artifact changes to make easier the review

@chenzhitong
Copy link
Member Author

It's better to avoid the artifact changes to make easier the review

Neo.IO.Helper.AsSerializable no longer exists

@chenzhitong
Copy link
Member Author

chenzhitong commented Nov 28, 2024 •
edited
Loading

Now UT won't run successfully, can you help with the modification. @shargon

shargon
shargon previously approved these changes Nov 28, 2024
View reviewed changes
@shargon
Copy link
Member

shargon commented Nov 28, 2024

Seems that coverage it's failing

shargon
shargon previously approved these changes Nov 28, 2024
View reviewed changes
@chenzhitong
Copy link
Member Author

chenzhitong commented Nov 28, 2024 •
edited
Loading

Now, out of 935 UT, 3 UTs are running failing (in my PC)

  1. Neo.Compiler.CSharp.UnitTests\UnitTest_Integer.cs Line 943
    Contract.IsPow2Long(long.MinValue) throw IndexOutOfRangeException

  2. Neo.SmartContract.Analyzer.UnitTests\DecimalUsageAnalyzerUnitTests.cs Line 83 DecimalVariable_ShouldChangeTo_LongVariable()

  3. Neo.SmartContract.Analyzer.UnitTests\DecimalUsageAnalyzerUnitTests.cs Line 115 DoubleVariable_ShouldChangeTo_LongVariable()

@Hecate2
Copy link
Contributor

Hecate2 commented Nov 29, 2024

UT failures at DecimalUsageAnalyzerUnitTests.cs seems to be \r\n and \n disputes only.

@Hecate2
Copy link
Contributor

Hecate2 commented Nov 29, 2024 •
edited
Loading

In Contract.IsPow2Long(long.MinValue), the OpCode AND at InstructionPointer=992 is not working correctly on -9223372036854775808 & -9223372036854775809. -9223372036854775808 is -2^63.

@Hecate2
Copy link
Contributor

Hecate2 commented Nov 29, 2024

microsoft/dotnet#1458

@shargon
Copy link
Member

shargon commented Nov 29, 2024

We should revert net9 in core

@shargon shargon mentioned this pull request Nov 29, 2024
Merged
@chenzhitong
Copy link
Member Author

https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/9.0/biginteger-limit

@shargon
Copy link
Member

shargon commented Nov 29, 2024

https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/9.0/biginteger-limit

It's another exception

@Jim8y
Copy link
Contributor

Jim8y commented Dec 5, 2024

https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/9.0/biginteger-limit

It's another exception

this limitation is way too large than what we enable~~

@Jim8y Jim8y added the blocked label Dec 9, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Dec 9, 2024

This will not be merged untill dotnet9 is stable enough, at least until next verison where biginteger issue can be fixed.

vncoelho
vncoelho reviewed Jan 16, 2025
View reviewed changes
.github/workflows/main.yml Outdated
@@ -6,7 +6,7 @@ on:
pull_request:

env:
DOTNET_VERSION: 8.0.x
DOTNET_VERSION: 9.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force SDK SDK 9.0.102 and check results
Include="..\Neo.ConsoleService\Neo.ConsoleService.csproj" />

vncoelho
vncoelho reviewed Jan 16, 2025
View reviewed changes
tests/Directory.Build.props
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.5.0" />
<PackageReference Include="MSTest.TestFramework" Version="3.5.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.12.4

Hecate2
Hecate2 previously approved these changes Jan 21, 2025
View reviewed changes
@Jim8y Jim8y merged commit db9248a into neo-project:master Jan 22, 2025
4 checks passed
shargon
shargon reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jim8y added a commit that referenced this pull request Feb 5, 2025
@Jim8y
Merge branch 'master' into test-optimizer
07b0260 
* master:
  fix: always check division overflow for int32 and int64 (#1287)
  Fix: some compiler warnings (#1288)
  use INC DEC (#1286)
  Update neo (#1285)
  Update: keep same sdk version with 'neo' (#1284)
  partially fix return in try; optimizer replaces JMP->ENDTRY with only ENDTRY (#1283)
  update to dotnet 9 (#1257)
  Added some styles (#1280)
  [`Fix`]: `checked(-x)` if x is int or long (#1281)
  Fix continue and goto (#1282)

# Conflicts:
#	tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Types_BigInteger.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

@vncoelho vncoelho vncoelho left review comments

@Jim8y Jim8y Jim8y approved these changes

@Hecate2 Hecate2 Hecate2 left review comments

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenzhitong @shargon @Hecate2 @Jim8y @vncoelho