Serialized storage cache

[shargon]

Description

Close #3145
Alternative to #3146

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Pending

Test Configuration:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[AnnaShaleva]

Good, it should work this way. But I'd suggest to process existing chains with this change in order to ensure that cache persisting logic works as expected.

[AnnaShaleva]

It's clear that Neo is always deployed in genesis block, but I'd suggest to use persisting block index instead of raw 0 because this way initialization code becomes more generic.

[shargon]

Also for the key?

[AnnaShaleva]

Use AddToCache instead of raw _serializedCacheChanges[typeof(T)] = value;?

[nan01ab]

Adding this to the IReadOnlyStore makes the interface more complex, and each implementation needs to be modified.

Another way:
Add a wrapper class for IStore

class SerializedCacheStore {
     private readonly IStore _store,
     public SerializedCache SerializedCache { get; } = new();

    public(IStore store) { _store = store}
}