-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable in Storage classes #3670
Merged
+139
−149
Merged
Changes from 5 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
417cdf2
Nullable
shargon 354f44f
Optimize
shargon 114c38c
Fix nullables
shargon 9a0b4dd
Fix ut
shargon 281f92a
More
shargon ace1edc
Update src/Neo/Persistence/DataCache.cs
shargon ead1cdf
Update src/Neo/Persistence/MemorySnapshot.cs
shargon 00cec14
Update src/Neo/Persistence/MemoryStore.cs
shargon ef37d0c
Remove pragma
shargon 6f139be
Merge branch 'storage-nullable' of https://github.com/neo-project/neo…
shargon 0334489
Clean
shargon 5cd1c53
SnapshotCache
shargon d0f034c
Change exception
shargon 54afc91
Merge branch 'master' into storage-nullable
shargon 2ef6457
Fix conflicts
shargon b5b09a4
Update src/Neo/Persistence/DataCache.cs
shargon 174b458
Merge branch 'master' into storage-nullable
shargon fe56246
Update src/Neo/Persistence/DataCache.cs
shargon 3bdae2d
Merge branch 'master' into storage-nullable
shargon 5af9001
Avoid logic change
shargon 771ee61
Merge branch 'storage-nullable' of https://github.com/neo-project/neo…
shargon 2cd6a79
Merge branch 'master' into storage-nullable
cschuchardt88 24cf4fb
Merge branch 'master' into storage-nullable
shargon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fail before, is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why
SnapshotCache
read from store, but write if thesnapshot
exists...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I want to avoid logic changes in this PR, I will throw a different exception, taking a look to the code it seems that it should always exists or it's a failure