Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Behavior when keyPrefix is null in different IStore.Seek impls. #3682

Merged
merged 4 commits into from
Jan 21, 2025
Merged

[Fix]: Behavior when keyPrefix is null in different IStore.Seek impls. #3682

merged 4 commits into from
Jan 21, 2025

Conversation

nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Jan 20, 2025

Description

LevelDbStore.Seek will throw an unexpected exception if keyPrefix is null.

But RocksDb.Store and MemoryStore will seek to the first key if keyPrefix is null.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nan01ab nan01ab changed the title [Fix]: Same behavior when keyPrefix is null in different IStore.Seek impls. [Fix]: Behavior when keyPrefix is null in different IStore.Seek impls. Jan 20, 2025
cschuchardt88
cschuchardt88 previously approved these changes Jan 21, 2025
View reviewed changes
shargon
shargon reviewed Jan 21, 2025
View reviewed changes
src/Plugins/LevelDBStore/IO/Data/LevelDB/Helper.cs
@@ -20,6 +20,8 @@ public static class Helper
{
public static IEnumerable<(byte[], byte[])> Seek(this DB db, ReadOptions options, byte[] keyOrPrefix, SeekDirection direction)
{
if (keyOrPrefix == null) keyOrPrefix = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in levelDb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in levelDb?

Same as MemoryStore and RocksDbStore.

src/Neo/Persistence/IReadOnlyStore.cs Outdated Show resolved Hide resolved
shargon
shargon approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@shargon shargon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will convert the project in nullable

@shargon shargon merged commit 856cb0c into neo-project:master Jan 21, 2025
7 checks passed
This was referenced Jan 21, 2025
Merged
Merged
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 31, 2025
@Jim8y
Merge branch 'master' into rc-v2
0281ad1 
* master: (43 commits)
  Fix `GetAndChange` warnings (neo-project#3702)
  `Murmur3` should not be cryptographic hash algorithm (neo-project#3668)
  Test: add tests for native contract id (neo-project#3697)
  Update nugets (neo-project#3692)
  [Core P2P] fix the bug (neo-project#3695)
  Add hardfork HF_Echidna (neo-project#3454)
  Fix: add lock for RocksDbStore.Snapshot to keep same behavior as MemoryStore and LevelDbStore (neo-project#3689)
  Nullable rocks db (neo-project#3686)
  Nullable leveldb (neo-project#3685)
  Enforcement Compiler Warnings (neo-project#3687)
  [`Update`] Dotnet & Compiler Version (neo-project#3684)
  [`Add`]: LevelDB Benchmarks (neo-project#3667)
  [`Fix`]: Behavior when `keyPrefix` is null in different `IStore.Seek` impls. (neo-project#3682)
  Improve calculatenetworkfee (neo-project#3674)
  more 2025 (neo-project#3678)
  Nullable in Storage classes (neo-project#3670)
  readonly (neo-project#3676)
  [Fix] Set max entries for `VerifyProof` in `statePlugin` (neo-project#3675)
  Neo.json.benchmarks (neo-project#3673)
  Happy new year 2025 (neo-project#3677)
  ...

# Conflicts:
#	src/Neo/Neo.csproj
#	src/Neo/ProtocolSettings.cs
#	src/Neo/SmartContract/ApplicationEngine.cs
#	src/Neo/SmartContract/Native/NeoToken.cs
#	src/Neo/SmartContract/Native/RoleManagement.cs
#	tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nan01ab @shargon @cschuchardt88