Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Dotnet & Compiler Version #3684

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 21, 2025

Change Log

  • Updated Dotnet version and enforced it.
    • note: BigInteger bug fix in version 9.0.102.
  • Changed compiler to latest.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Changed compiler to latest
Disabled warning in brenchmarks
@cschuchardt88 cschuchardt88 changed the title ['Updates'] Environment Configurations [Updates] Environment Configurations Jan 21, 2025
benchmarks/Directory.Build.props Outdated Show resolved Hide resolved
benchmarks/Directory.Build.props Outdated Show resolved Hide resolved
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschuchardt88 you mix things, you want to update net version do it, style is a different thing

@cschuchardt88 cschuchardt88 changed the title [Updates] Environment Configurations [Update] Dotnet & Compiler Version Jan 21, 2025
@cschuchardt88
Copy link
Member Author

@cschuchardt88 you mix things, you want to update net version do it, style is a different thing

done

@cschuchardt88 cschuchardt88 requested a review from shargon January 21, 2025 10:22
@shargon shargon merged commit fe22fb8 into neo-project:master Jan 21, 2025
7 checks passed
@shargon shargon deleted the fix/dotnet-version branch January 21, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants