WIP: Rel concurrency issue proving test cases #1704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1704 +/- ##
===========================================
- Coverage 93.43% 43.23% -50.20%
===========================================
Files 128 106 -22
Lines 5909 4947 -962
===========================================
- Hits 5521 2139 -3382
- Misses 388 2808 +2420 ☔ View full report in Codecov by Sentry. |
mrhardikjoshi
commented
Nov 30, 2023
|
|
||
| # to_node.from_class only returns 1 result but in db there are two rels associated with this node | ||
| # this assertion fails with with result 2 proving the presence of bug | ||
| expect(ActiveGraph::Base.query("MATCH (node2:`ToClass`)<-[rel1:`HAS_REL`]-(from_class:`FromClass`) return from_class").to_a.size).to eq(1) |
There was a problem hiding this comment.
Screenshot of the data
mrhardikjoshi
commented
Nov 30, 2023
|
|
||
| # to_node.from_class only returns 1 result but in db there are two rels associated with this node | ||
| # this assertion fails with with result 2 proving the presence of bug | ||
| expect(ActiveGraph::Base.query("MATCH (node2:`ToClass`)<-[rel1:`HAS_REL`]-(from_class:`FromClass`) return from_class").to_a.size).to eq(1) |
There was a problem hiding this comment.
Screenshot of the data
|
Closing as the fix for this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When a has_one association of a node is updated concurrently, it does not respect the
has_oneassociation and due to race condition it may result in wrong data. This is very low probable scenario.