Fixed proper response to ServiceServer not running, No such service f…

…rom remote client.
neocoretechs · Dec 23, 2020 · db63e67 · db63e67
1 parent 3fb5a3c
commit db63e67
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/main/java/org/ros/internal/node/rpc/MasterRpcEndpointImpl.java b/src/main/java/org/ros/internal/node/rpc/MasterRpcEndpointImpl.java
@@ -143,14 +143,15 @@ public List<Object> unregisterSubscriber(String callerId, String topicName, Stri
 
   @Override
   public List<Object> lookupService(String callerId, String serviceName) {
-	  RemoteRequestInterface rri = new RemoteRequest("org.ros.internal.node.server.master.MasterServer", 
+	RemoteRequestInterface rri = new RemoteRequest("org.ros.internal.node.server.master.MasterServer", 
 			  "lookupService",
 			  GraphName.of(serviceName));
-    InetSocketAddress slaveUri = (InetSocketAddress) remoteMaster.queue(rri);//master.lookupService(GraphName.of(serviceName));
-    if (slaveUri != null) {
+	Object sock = remoteMaster.queue(rri);//master.lookupService(GraphName.of(serviceName)); 
+    if (sock != null && sock instanceof InetSocketAddress) {
+      InetSocketAddress slaveUri = (InetSocketAddress)sock;
       return Response.newSuccess("Success", slaveUri.toString()).toList();
     }
-    return Response.newError("No such service.", null).toList();
+    return Response.newError("No such service.", callerId+" "+serviceName).toList();
   }
 
   @Override