Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FMLModType.LANGPROVIDER (you can use LIBRARY instead) #105

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

Technici4n
Copy link
Member

There was in fact no reason to have this separate mod type - it didn't do anything special.

Closes #71.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 27, 2024

  • Publish PR to GitHub Packages

Last commit published: 63ad0778e65846b82b369de211068209d7cd1d51.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #105' // https://github.com/neoforged/FancyModLoader/pull/105
        url 'https://prmaven.neoforged.net/FancyModLoader/pr105'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'spi')
            includeModule('net.neoforged.fancymodloader', 'loader')
        }
    }
}

Copy link
Contributor

@thedarkcolour thedarkcolour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, keeping LANGPROVIDER and LIBRARY code separate is tedious.

@marchermans marchermans merged commit 10fc3da into neoforged:main Mar 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate/remove LANGPROVIDER jar type
4 participants