Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update foojay and refactor EventBusSubscriber as an outer class #111

Closed
wants to merge 2 commits into from
Closed

Update foojay and refactor EventBusSubscriber as an outer class #111

wants to merge 2 commits into from

Conversation

Spinoscythe
Copy link

Update foojay and refactor EventBusSubscriber as an outer class
Fixes #101

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

Technici4n
Technici4n requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more thought than just blindly applying an issue. Chances are that other language providers are also using these classes.

@Spinoscythe
Copy link
Author

FML needs more global vision than that

@Spinoscythe Spinoscythe closed this Apr 3, 2024
@Spinoscythe Spinoscythe deleted the issuefix/move-ebs branch April 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technici4n Technici4n Technici4n requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move EventBusSubscriber into outer class
2 participants
@Spinoscythe @Technici4n