Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce ModConfig#getHandler #46

Closed
wants to merge 1 commit into from
Closed

Reintroduce ModConfig#getHandler #46

wants to merge 1 commit into from

Conversation

pupnewfster
Copy link
Member

Adds back the ModConfig#getHandler method that was removed in #40 so that mods can actually override the type handler.

@Technici4n
Copy link
Member

Not a fan of adding back a method that shouldn't exist. IMO, we should fix your use case properly by tweaking how configs are loaded.

@marchermans
Copy link
Contributor

oved in #40 so that mods can actua

This was per review rejected.
The whole point of removing the handler is so that TOML is the default that should be used. It is practically the only one supported, and I see no reason to support other formats.

@pupnewfster
Copy link
Member Author

Superseded by #48

@pupnewfster pupnewfster deleted the config_handlers branch December 11, 2023 20:48
shartte pushed a commit that referenced this pull request Dec 22, 2024
@Matyrobbrt
Build and publish with GitHub actions (#46)
f428652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pupnewfster @Technici4n @marchermans