Add a subproject with a JUnit session listener #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Dec 15, 2023
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitDevLaunchTarget.java
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitDevLaunchTarget.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitUserDevLaunchTarget.java
Outdated
Show resolved
Hide resolved
|
Outside of some documentation as to what the components do, this is good from my end. |
shartte
requested changes
Jan 20, 2024
shartte
previously approved these changes
Jan 20, 2024
Technici4n
reviewed
Jan 23, 2024
Technici4n
reviewed
Jan 23, 2024
junit/src/main/resources/META-INF/services/org.junit.platform.launcher.LauncherSessionListener
Show resolved
Hide resolved
Technici4n
reviewed
Jan 23, 2024
|
In reality it will almost always not be on module path
Technici4n ***@***.***> schrieb am Di., 23. Jan. 2024, 14:53:
… ***@***.**** commented on this pull request.
------------------------------
In
junit/src/main/resources/META-INF/services/org.junit.platform.launcher.LauncherSessionListener
<#54 (comment)>
:
> @@ -0,0 +1 @@
+net.neoforged.fml.junit.JUnitService
Any reason to specify the services both in the module-info and in
META-INF? Do we expect users to launch this outside of the module path?
—
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJT6V2GBNKB2DKDWQJDUITYP66FLAVCNFSM6AAAAABAW3XOEKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYHA2DSMJWGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Last commit published: 8a40ebc2d39104fce7bbc0a0b510bfef191af0a4. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #54' // https://github.com/neoforged/FancyModLoader/pull/54
url 'https://prmaven.neoforged.net/FancyModLoader/pr54'
content {
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
}
}
} |
marchermans
approved these changes
May 18, 2024
marchermans
approved these changes
May 26, 2024
shartte
pushed a commit
that referenced
this pull request
Dec 22, 2024
This will let frameworks like mixin define additional packages in the
GAME layer for runtime generated classes with the following additional
code in a transformation service:
```java
@OverRide
public List<Resource> completeScan(final IModuleLayerManager layerManager) {
try {
return List.of(
new Resource(IModuleLayerManager.Layer.GAME, List.of(
new VirtualJar(
"mixin_generated_classes",
Path.of(getClass().getProtectionDomain().getCodeSource().getLocation().toURI()),
Constants.SYNTHETIC_PACKAGE,
Constants.SYNTHETIC_PACKAGE + ".args"))));
} catch (URISyntaxException e) {
throw new RuntimeException(e);
}
```
Fixes McModLauncher/modlauncher#90. Tested with a forgedev `@ModifyArgs`
mixin :)
---------
Co-authored-by: Matyrobbrt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow running JUnits in a bootstrapped Minecraft environment.