Only crash if mods found by the MC locator (i.e. dev mods) are using the mandatory field
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
changed the title
mandatory field is usedmandatory field
Matyrobbrt
changed the title
mandatory fieldmandatory field
sciwhiz12
approved these changes
Dec 23, 2023
Matyrobbrt
pushed a commit
to neoforged/NeoForge
that referenced
this pull request
Dec 24, 2023
Update FML to 2.0.6 to include neoforged/FancyModLoader#60 Replace SPI dependency with the FML SPI artifact, since the old one was deprecated in neoforged/FancyModLoader#58 Fixes #407
2 tasks
shartte
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the mod info parser only crash in-dev if mods found by the MC locator (i.e. dev mods) are using the
mandatoryfield instead of thetypeone, preventing dependencies from causing the error.Fixes [not really, Neo bump required] neoforged/NeoForge#407