Remove naming related functionality from FML #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Thoughts on keeping a |
|
I think it makes sense to keep it, but renamed to |
|
Yeah I am reworking this towards deprecation of the current class. |
shartte
force-pushed
the
remove-naming-service
branch
2 times, most recently
from
0e632e9 to
ad1297e
Compare
shartte
force-pushed
the
remove-naming-service
branch
from
ad1297e to
89cd5d3
Compare
|
Should be combined with bumping ML, which also removes part of this functionality. |
shartte
pushed a commit
that referenced
this pull request
Dec 22, 2024
Currently, SJH throws when building a module descriptor for jars which contain files in META-INF/services which aren't valid. All this PR does is filter out these invalid files: - I've added a set of known "naughty" service files which don't follow the format correctly - It was mentioned in Discord that certain Groovy libraries define extensions with these invalid service files so I wanted to include these too - JLine 3.22.0 and above define a nested file in `META-INF/services/org/jline/terminal/provider/` which doesn't follow the service file format (it's in fact a properties file). This causes SJH to throw because `exec` is not within a named package, and is blocking upgrading to newer versions of JLine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we remap to Mojmap runtime, I'd suggest we remove the functionality in FML that remaps intermediary<->Mojmap/MCP since it should not be functional anymore.
The
ObfuscationReflectionHelperhas been renamed toReflectionHelperwith the same interface. Naming-related functionality has been removed from it, and the existing class been marked as deprecated for removal.This also removes an unused FML environment key
LOCATORCLASSLOADERfor which I could not find any uses.