Remove hard casts to ModFile and co
#67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
added
bug
Su5eD
approved these changes
Jan 13, 2024
marchermans
requested changes
Feb 11, 2024
Comment on lines
-108
to
-112
| FMLLoader.getLoadingModList().getModFiles().stream() | ||
| .filter(ModFileInfo::missingLicense) | ||
| .filter(modFileInfo -> modFileInfo.getMods().stream().noneMatch(thisModInfo -> this.loadingExceptions.stream().map(ModLoadingException::getModInfo).anyMatch(otherInfo -> otherInfo == thisModInfo))) //Ignore files where any other mod already encountered an error | ||
| .map(modFileInfo -> new ModLoadingException(null, ModLoadingStage.VALIDATE, "fml.modloading.missinglicense", null, modFileInfo.getFile())) | ||
| .forEach(this.loadingExceptions::add); |
There was a problem hiding this comment.
This change is not part of the proposed changes why did you add it?
|
My personal opinion is that making |
|
@Matyrobbrt Do we wanna kill this? |
|
We ended up marking IModFile as NonExtendable instead. |
shartte
added a commit
that referenced
this pull request
Dec 22, 2024
* Removed deprecated methods (cherry picked from commit 72f8d15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hard casts to
ModFile, to makeIModFileextendable. In order to achieve this, a few more methods were added to SPI.