Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data map removals being required to exist #1886

Merged

Conversation

Matyrobbrt
Copy link
Member

This PR fixes the oversight that makes data map removals required, erroring if they are not resolvable (such as being for an inexistent value). Removals should be optional.

This PR fixes the oversight that makes data map removals required, erroring if they are not resolvable (such as being for an inexistent value). Removals should be optional.
@Matyrobbrt Matyrobbrt added bug A bug or error data driven This request involves a data driven system 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 21, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 21, 2025

  • Publish PR to GitHub Packages

Last commit published: d3c7a45ecec80691db47a8d6d95790c2dbb881c5.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1886' // https://github.com/neoforged/NeoForge/pull/1886
        url 'https://prmaven.neoforged.net/NeoForge/pr1886'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1886.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1886
cd NeoForge-pr1886
curl -L https://prmaven.neoforged.net/NeoForge/pr1886/net/neoforged/neoforge/21.4.76-beta-pr-1886-fix-dmap-removals-being-required/mdk-pr1886.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt Matyrobbrt merged commit 102cf83 into neoforged:1.21.x Jan 23, 2025
6 checks passed
@Matyrobbrt Matyrobbrt deleted the fix-dmap-removals-being-required branch January 23, 2025 19:11
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.74-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error data driven This request involves a data driven system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants