Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config screen event registration to an event #560

Closed
wants to merge 1 commit into from

Conversation

Technici4n
Copy link
Member

So that we can deprecate the FML extension point system for removal.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 81b94a655b77ea274a7131a3ec12ebd5e053d518.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #560' // https://github.com/neoforged/NeoForge/pull/560
        url 'https://prmaven.neoforged.net/NeoForge/pr560'
        content {
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr560.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr560
cd NeoForge-pr560
curl -L https://prmaven.neoforged.net/NeoForge/pr560/net/neoforged/neoforge/20.4.126-beta-pr-560-config-screen-event/mdk-pr560.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@dima-dencep
Copy link
Contributor

dima-dencep commented Jan 23, 2024

I think it's better to register and load configs immediately when they are created or when something tries to get some value

@Technici4n
Copy link
Member Author

Alternative: simplify extension point API: neoforged/FancyModLoader#80.

@sciwhiz12 sciwhiz12 added enhancement New (or improvement to existing) feature or request 1.20 Targeted at Minecraft 1.20 labels Feb 3, 2024
@Technici4n Technici4n closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Targeted at Minecraft 1.20 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants