Fix spaces in Gradle user home breaking IntelliJ run configurations #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit does not explain why it is fixed..... We were already quoting the programme arguments it is crashing over. What do jvm arguments have to do with this? |
|
The module classpath is a jvm argument. See: https://discord.com/channels/313125603924639766/801175194298744902/1178110006088974376 |
In Eclipse Run configurations, the JVM arguments are passed as an array and Eclipse seems to take care of escaping individual arguments. For IntelliJ, we have to do that. And as maty says, the module path (which contains paths pointing into GRADLE_USER_HOME) will be a JVM argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce this in IntelliJ:
Fixes #54