Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Gradles approach for serializing System properties #59

Merged
merged 1 commit into from
Nov 28, 2023

Switch to Gradles approach for serializing System properties (which e…

93c2e44
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Switch to Gradles approach for serializing System properties #59

Switch to Gradles approach for serializing System properties (which e…
93c2e44
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Report succeeded Nov 27, 2023 in 1s

Test Report ✅

Tests passed successfully

✅ junit.xml

73 tests were completed in 443s with 69 passed, 0 failed and 4 skipped.

Test suite Passed Failed Skipped Time
net.neoforged.gradle.common.extensions.dependency.replacement.DependencyReplacementsExtensionTest 15✅ 8s
net.neoforged.gradle.neoform.deobfuscation.ObfuscationAndDeobfuscationTestSpecification 1✅ 3ms
net.neoforged.gradle.neoform.dependency.NeoformDependencyManagerTest 2✅ 17s
net.neoforged.gradle.neoform.FunctionalTests 3✅ 443s
net.neoforged.gradle.neoform.NeoFormPluginTests 4✅ 1s
net.neoforged.gradle.userdev.CompatibilityTests 1⚪ 0ms
net.neoforged.gradle.userdev.FunctionalTests 3⚪ 3ms
net.neoforged.gradle.userdev.UserDevPluginTests 4✅ 27s
net.neoforged.gradle.util.AdaptingZipBuildingFileTreeVisitorTest 10✅ 3s
net.neoforged.gradle.util.CopyingFileTreeVisitorTest 7✅ 3s
net.neoforged.gradle.util.DelegatingFileTreeVisitorTest 2✅ 2s
net.neoforged.gradle.util.ModuleDependencyUtilsTest 6✅ 365ms
net.neoforged.gradle.util.ResolvedDependencyUtilsTest 6✅ 327ms
net.neoforged.gradle.util.ZipBuildingFileTreeVisitorTest 9✅ 1s

✅ net.neoforged.gradle.common.extensions.dependency.replacement.DependencyReplacementsExtensionTest

✅ callingHandleDependencyReplacementRemovesTheOriginalDependency()
✅ callingHandleDependencyReplacementAlwaysInvokesTheIdeReplacementHandlerWhenNoImportIsRunning()
✅ callingHandleDependencyReplacementAlwaysInvokesTheIdeReplacementHandlerWhenAnImportIsRunning()
✅ callingHandleDependencyReplacementDoesNotRegisterTheGenerationTaskWhenAlreadyDone()
✅ aDependencyReplacementIsRegisteredForAnExternalModuleDependency()
✅ invokingOnPostDefinitionBakesDoesNotRunTheRegisteredCallbacksIfTheStateHasAFailure()
✅ callingHandleDependencyReplacementAlwaysInvokesTheGradleReplacementHandler()
✅ aConfigureCallbackForAllConfigurationsInAGivenProjectIsAddedOnConstruction()
✅ aCallbackHandlerIsAddedToEachConfigurationWhenOneIsConfigured()
✅ callingHandleDependencyReplacementToRegistersTheGenerationTaskWhenNotDoneYet()
✅ callingHandleConfigurationRegistersDependencyMonitor()
✅ aDependencyReplacementProperlyConfiguresTheIvyReplacementWithItsOwnExternalModuleDependencies()
✅ invokingOnPostDefinitionBakesRunsTheRegisteredCallbacksIfTheStateHasNoFailure()
✅ aDependencyReplacementProperlyConfiguresTheIvyReplacement()
✅ aDependencyReplacementIsOnlyRegisteredForAnythingThatIsNotAnExternalModuleDependency()

✅ net.neoforged.gradle.neoform.deobfuscation.ObfuscationAndDeobfuscationTestSpecification

✅ supportObfuscationAndDeobfuscation

✅ net.neoforged.gradle.neoform.dependency.NeoformDependencyManagerTest

✅ adding a dependency to something other then neoform minecraft works
✅ adding a dependency on neoform minecraft with exact version works

✅ net.neoforged.gradle.neoform.FunctionalTests

✅ a mod with neoform as dependency can run the apply official mappings task
✅ neoform applies user ATs and allows remapped compiling
✅ neoform re-setup uses a build-cache

✅ net.neoforged.gradle.neoform.NeoFormPluginTests

✅ can apply plugin
✅ applying neoform plugin applies common plugin
✅ applying neoform plugin adds a neoFormRuntime configurable extension
✅ applying neoform plugin adds the required maven plugins

✅ net.neoforged.gradle.userdev.CompatibilityTests

⚪ a mod with userdev as dependency can run the patch task for that dependency

✅ net.neoforged.gradle.userdev.FunctionalTests

⚪ a mod with userdev as dependency can run the patch task for that dependency
⚪ a mod with userdev as dependency and official mappings can compile through gradle
⚪ the userdev runtime by default supports the build cache

✅ net.neoforged.gradle.userdev.UserDevPluginTests

✅ applying userdev plugin succeeds
✅ applying userdev plugin applies neoform plugin
✅ applying userdev plugin applies forge extension
✅ applying userdev plugin applies userDev runtime extension

✅ net.neoforged.gradle.util.AdaptingZipBuildingFileTreeVisitorTest

✅ visitingAFileCreatesAnEntryInZipAndCopiesItUsingAStream()
✅ throwingAZipExceptionForAnythingOtherThenDuplicateDirectoriesThrowsAnException()
✅ throwingAZipExceptionForDuplicateDirectoriesDoesNotThrowAnException()
✅ throwingAnIOExceptionDuringEntryClosingWhileVisitingADirectoryThrowsAnException()
✅ visitingADirectoryCreatesAnEntryInZip()
✅ throwingAnIOExceptionDuringEntryPuttingWhileVisitingAFileThrowsAnException()
✅ throwingAnIOExceptionDuringEntryPuttingWhileVisitingADirectoryThrowsAnException()
✅ throwingAnIOExceptionDuringCopyingWhileVisitingAFileThrowsAnException()
✅ throwingAnIOExceptionDuringEntryClosingWhileVisitingAFileThrowsAnException()
✅ visitingAFileInvokesAdapterWhichCanChooseToNotCopyTheFileContentsButStillCreatesTheFile()

✅ net.neoforged.gradle.util.CopyingFileTreeVisitorTest

✅ visitingAFileCreatesAFileInTheTargetAndCopiesItsContent()
✅ passingInAFileUsesItsPath()
✅ visitingAFileCreatesAFileInTheTarget()
✅ visitingADirectoryCreatesADirectoryInTheTarget()
✅ passingANotExistingDirectoryCreatesIt()
✅ tryingToUseAFileAsATargetThrowsARuntimeException()
✅ passingInADirectoryWithContentDeletesTheContent()

✅ net.neoforged.gradle.util.DelegatingFileTreeVisitorTest

✅ visitingADirectoryInvokesDelegate()
✅ visitingAFileInvokesDelegate()

✅ net.neoforged.gradle.util.ModuleDependencyUtilsTest

✅ returnsANullExtensionWhenTheFirstArtifactHasNoExtension()
✅ returnsTheExtensionOfTheFirstArtifact()
✅ returnsANullClassifierWhenNoArtifactsArePresent()
✅ returnsTheClassifierOfTheFirstArtifact()
✅ returnsANullExtensionWhenNoArtifactsArePresent()
✅ returnsANullClassifierWhenTheFirstArtifactHasNoClassifier()

✅ net.neoforged.gradle.util.ResolvedDependencyUtilsTest

✅ returnsANullExtensionWhenTheFirstArtifactHasNoExtension()
✅ returnsTheExtensionOfTheFirstArtifact()
✅ returnsANullClassifierWhenNoArtifactsArePresent()
✅ returnsTheClassifierOfTheFirstArtifact()
✅ returnsANullExtensionWhenNoArtifactsArePresent()
✅ returnsANullClassifierWhenTheFirstArtifactHasNoClassifier()

✅ net.neoforged.gradle.util.ZipBuildingFileTreeVisitorTest

✅ visitingAFileCreatesAnEntryInZipAndCopiesItUsingAStream()
✅ throwingAZipExceptionForAnythingOtherThenDuplicateDirectoriesThrowsAnException()
✅ throwingAZipExceptionForDuplicateDirectoriesDoesNotThrowAnException()
✅ throwingAnIOExceptionDuringEntryClosingWhileVisitingADirectoryThrowsAnException()
✅ visitingADirectoryCreatesAnEntryInZip()
✅ throwingAnIOExceptionDuringEntryPuttingWhileVisitingAFileThrowsAnException()
✅ throwingAnIOExceptionDuringEntryPuttingWhileVisitingADirectoryThrowsAnException()
✅ throwingAnIOExceptionDuringCopyingWhileVisitingAFileThrowsAnException()
✅ throwingAnIOExceptionDuringEntryClosingWhileVisitingAFileThrowsAnException()