Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env variable for image_core url #48

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

croche2574
Copy link

Allows for setting the url for image_core to something other than localhost, useful for setting up unraid containers for the individual applications

@croche2574
Copy link
Author

Added the rest of the necessary changes to set up the containers with unraid, made some small edits to the build yml for pro (can be ignored), added a build script for the image to text generator docker image including a command that ensures enough room exists to finish the build

@neonwatty
Copy link
Owner

Thanks for contributing!

A few comments regarding the updates!

  • .github/workflows/image-to-text-build.yml: in my testing the current image-to-text image is too large for github's free runner - can you verify this? At present this is because the model weights are included in the image - making the experience "batteries included" by just pulling the image. (In the future we could certainly de-couple and not bake the weights in - especially if additional models are included giving users options - maybe we should do that?)

  • regarding replacing localhost with an env variable: no issue with the idea, but making this adjustment creates additional cascading required updates like

  1. the path should default back to localhost if no HOST_IP or HOST_URL variable is set by the user
  2. variables should not be set by hand, and should be stored in an .env file would - which would require appropriate additions be made in both containers (e.g., dotenv in the case of Python is needed to hoist variables)
  3. updates to the docker-compose files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants