-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backport cms 4.0.x - Django 3.2 with Python 3.8 & 3.9 support, including update tooling #77
Conversation
* Compatibility with Django-CMS 3.7.2 Co-authored-by: Fabrice Pardo <[email protected]>
* Bump develop version [ci skip] * Remove useless try/except as it is an old syntax * Fix HISTORY.rst syntax * Remove leftovers from template project Co-authored-by: Iacopo Spalletti <[email protected]>
* Add support for django-app-enabler * Update readme * Update dependencies
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…including update tooling
* Add support for Django 3.2 / django CMS 3.10 * Fix github actions matrix
* fix serialization issue * added newsfragment Co-authored-by: Iacopo Spalletti <[email protected]>
* Fix error when populating the toolbar on page types * Add test
Codecov Report
@@ Coverage Diff @@
## support/4.0.x #77 +/- ##
================================================
Coverage ? 94.56%
================================================
Files ? 9
Lines ? 184
Branches ? 22
================================================
Hits ? 174
Misses ? 7
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only minor thing is the pinning of djangocms-verisoning. I updated the authors file but that could be auto populated so may undo any changes.
Also, great to have you back around @yakky, we genuinely missed you man.
|
||
Development Lead | ||
---------------- | ||
|
||
* Iacopo Spalletti <i.spalletti@nephila.it> | ||
* Iacopo Spalletti <i.spalletti@nephila.digital> | ||
|
||
Contributors | ||
------------ | ||
|
||
* Anton Egorov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is auto populated.
* Anton Egorov | |
* Aiky30 | |
* Anton Egorov |
@@ -3,3 +3,4 @@ coveralls | |||
flake8>=2.1.0 | |||
tox>=2.0 | |||
django-app-helper | |||
https://github.com/Aiky30/djangocms-versioning/tarball/feature/django-32-compat#egg=djangocms-versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Aiky30/djangocms-versioning/tarball/feature/django-32-compat#egg=djangocms-versioning | |
https://github.com/django-cms/djangocms-versioning/tarball/master#egg=djangocms-versioning |
This was an old pin before 3.2 changes were merged.
Replaced by #83 which includes the whole set of django CMS 4 changes |
Description
Merge code from #70 with updated develop
References
Fix #70
Checklist
inv lint
changes
file included (see docs)