added subnet per cluster with different network contexts #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
yes we could but I avoided doing it since the git credentials are in there. If we go for gitea this is a different case. |
WE can leave the values for those fields blank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: this PR also requires a change in the IPAM/NF-injector controller, NAD-injector fn and the ipam package in the Nephio-packages !!!!
This PR configures a subnet per cluster per network-type (internal/external/sba/internet/etc) iso a single subnet for all clusters.
This enables a more real world environment, since a single broadcast network across clusters is not realistic.