-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding offline installer #147
Conversation
fix #145 |
Update cni task
added subnet per cluster with different network-tx to offline-package
|
Why are we not making this an option of the existing install? User could have the option to choose one or the other through an option. |
Sure, is it okay to have a property like "installation_mode: offline/online" and use this property in the yaml task files to execute online or offline installation? |
/easycla |
@@ -56,6 +57,8 @@ all: | |||
host_min_root_disk_space: 50 # minimum required disk space before install; value in GB | |||
tmp_directory: "/tmp" | |||
bin_directory: "/usr/local/bin" | |||
installer_lib: <provide full path for installer_lib direcotry under nephio-ansible-install-offline> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would the value for this field look like? Is nephio-ansible-install-offline a directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the directory to keep library files for offline installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For using the offline installation, we just need to set installation_mode property in nephio.yaml to offline.
Looks like it needs a rebase. |
I used the GH UI to try to resolve the conflicts...let's see how it looks after that. |
Please review the change I made... |
Looks good to me, thanks! |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnbelamaric, shailendrarjpt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Copied the Nephio-ansible-install directory to Nephio-ansible-install-offline directory to add offline installer.
Added clab install offline.