Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding offline installer #147

Merged
merged 34 commits into from
May 4, 2023
Merged

Conversation

shailendrarjpt
Copy link
Contributor

Copied the Nephio-ansible-install directory to Nephio-ansible-install-offline directory to add offline installer.
Added clab install offline.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@shailendrarjpt shailendrarjpt changed the title Adding offline installer - clab Adding offline installer Apr 10, 2023
@ganchandrasekaran
Copy link
Contributor

ganchandrasekaran commented Apr 10, 2023

fix #145

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@henderiw
Copy link
Contributor

Why are we not making this an option of the existing install? User could have the option to choose one or the other through an option.

@shailendrarjpt
Copy link
Contributor Author

Sure, is it okay to have a property like "installation_mode: offline/online" and use this property in the yaml task files to execute online or offline installation?

@WillsonHG
Copy link

/easycla

@@ -56,6 +57,8 @@ all:
host_min_root_disk_space: 50 # minimum required disk space before install; value in GB
tmp_directory: "/tmp"
bin_directory: "/usr/local/bin"
installer_lib: <provide full path for installer_lib direcotry under nephio-ansible-install-offline>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would the value for this field look like? Is nephio-ansible-install-offline a directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the directory to keep library files for offline installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For using the offline installation, we just need to set installation_mode property in nephio.yaml to offline.

@johnbelamaric
Copy link
Contributor

Looks like it needs a rebase.

@shailendrarjpt
Copy link
Contributor Author

Hey I resolved the conflicts and rebased but it still showing conflicts.
Now if I am doing rebase in VScode there is no conflicts its showing.

Please let me know how to rebase it to fix this.

@johnbelamaric
Copy link
Contributor

I used the GH UI to try to resolve the conflicts...let's see how it looks after that.

@johnbelamaric
Copy link
Contributor

Please review the change I made...

@shailendrarjpt
Copy link
Contributor Author

Please review the change I made...

Looks good to me, thanks!

@johnbelamaric
Copy link
Contributor

/approve
/lgtm

@nephio-prow
Copy link

nephio-prow bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnbelamaric, shailendrarjpt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnbelamaric johnbelamaric merged commit 7e76ac6 into nephio-experimental:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants