Adding readinessProbe and livenessProbe probes to porch #92
Conversation
|
Hi Team, @liamfallon @efiacor can you review these changes |
|
Hi Team, |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson, kushnaidu, liamfallon, mansoor17syed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I wanted @efiacor to take a quick look. |
There was a problem hiding this comment.
Hi @mansoor17syed , thank you for adding some best practice elements to the deployments.
The changes for the controllers should be fine as they are served by these - https://github.com/nephio-project/porch/blob/d7839690ca85fbb64669ae4158d5679c9ee29713/controllers/main.go#L174
but I am not 100% sure on the probes for the porch api server.
| @@ -80,6 +80,28 @@ spec: | |||
| - --repo-sync-frequency=3m | |||
| - --disable-validating-admissions-policy=true | |||
| - --max-request-body-size=6291456 # Keep this in sync with function-runner's corresponding argument | |||
|
|
|||
| #adding livenessProbes and readinessProbes for porch server | |||
| livenessProbe: | |||
There was a problem hiding this comment.
These are useful to meet best practices but may need some more investigation.
As the porch api server is a k8s aggregated api server, I am not 100% sure if we need to implement our own probe endpoints.
Also, the docs mention that /healthz is now deprecated and to use /livez instead.
https://kubernetes.io/docs/reference/using-api/health-checks/#individual-health-checks
Finally, unfortunately, the changes here are not "tested" on each PR commit so and breaking change only gets picked up when it gets deployed to the sandbox by the test-infra project. This is something we plan to address.
The configs here would need to be tailored to that env, and potentially monitored and updated if necessary.
There was a problem hiding this comment.
We may need to add something to the server config to handle the checks, such as - https://github.com/kubernetes/apiserver/blob/master/pkg/server/healthz.go#L91
Somewhere here maybe - https://github.com/nephio-project/porch/blob/main/pkg/apiserver/apiserver.go#L275
No description provided.