-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code-first): Use capitalized case for enums in code-first #1852
Open
kasvith
wants to merge
11
commits into
nestjs:master
Choose a base branch
from
kasvith:feature-enum-case-mapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ff30025
feat(): added enum case mapper
kasvith cc2526e
feat(): added enum metadata
kasvith 628e73c
feat(): added register enum type factory option
kasvith a2cc1c4
test(): added tests for enum capitalization
kasvith 89afa7b
refactor: change name of variable
kasvith 7df98e0
fix(code-first): use replaceAll for uppercase mapper
kasvith 498775e
test(): added tests for enum capitalization
kasvith f497019
fix(code-first): respect new apollo loader
kasvith 406113a
refactor(code-first): rearrange import
kasvith c2f9576
test(code-first): added tests for enum capitalization
kasvith b5b647b
test(code-first): added more testcases to enum case mapper
kasvith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,18 @@ | ||
import { Query, Resolver } from '@nestjs/graphql'; | ||
import { Args, Query, Resolver } from '@nestjs/graphql'; | ||
import { CatType } from '../enums/cat-type.enum'; | ||
|
||
@Resolver() | ||
export class CatsResolver { | ||
@Query((returns) => String) | ||
getAnimalName(): string { | ||
return 'cat'; | ||
} | ||
|
||
@Query((returns) => CatType) | ||
catType( | ||
@Args({ name: 'catType', type: () => CatType }) | ||
catType: CatType, | ||
): CatType { | ||
return catType; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { registerEnumType } from '@nestjs/graphql'; | ||
|
||
export enum CatType { | ||
PersianCat = 'persian-cat', | ||
MaineCoon = 'maine-coon', | ||
Ragdoll = 'ragdoll', | ||
SomeNewAwesomeCat = 'some-new-awesome-cat', | ||
SomeWEIRDCat = 'some-weird-cat', | ||
anotherAwesomeCat = 'another-awesome-cat', | ||
} | ||
|
||
registerEnumType(CatType, { | ||
name: 'CatType', | ||
description: 'Distinguish cats', | ||
mapToUppercase: true, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasvith this option seems to be a single purpose one. Would it be better to take a key transform function so that people can use any function they want for the enum keys? toUppercase could then become the default and the feature would become a lot more useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mareksuscak
By convention GraphQL enums are UPPER_CASE literals, i dont see a usecase to have a transformer function and make this much more complicated than it is now
https://www.apollographql.com/tutorials/side-quest-intermediate-schema-design/02-the-enum-type