Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): allow to set custom transport to decorators #9347

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

xavierchow
Copy link
Contributor

@xavierchow xavierchow commented Mar 17, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number:#9341

What is the new behavior?

A self-defined Symbol from a custom transpoter can be set for EventPattern & MessagePattern decorator to avoid binding patterns to wrong microservices in multiple microservices circumstances.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@xavierchow xavierchow force-pushed the feat-custom-transpoter-id branch from 041bbcc to 4539568 Compare March 17, 2022 01:22
@xavierchow
Copy link
Contributor Author

sending nestjs/docs.nestjs.com#2247 for doc updates as well.

@xavierchow
Copy link
Contributor Author

@kamilmysliwiec I'm wondering if there is any action item from my side?

I saw @Tony133 has approved the changes but the Github is saying it needs a maintainer to approve.

@kamilmysliwiec kamilmysliwiec merged commit a839234 into nestjs:master Mar 21, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@xavierchow xavierchow deleted the feat-custom-transpoter-id branch March 21, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants