Additional features/settings added to fabric creation #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewiebe
reviewed
Dec 10, 2024
| @@ -35,6 +35,8 @@ factory_defaults: | |||
| advertise_pip: false | |||
| advertise_pip_border_only: true | |||
| domain_id_range: 1-1000 | |||
| fabric_vpc_qos: false | |||
There was a problem hiding this comment.
Please open a PR to add these to the internal repo defaults since that is the source of truth for defaults. Reminds me that I need to make sure we refreshing the set of defaults from that repo for each release.
There was a problem hiding this comment.
I discovered that we indeed where a bit out of sync. Opened a PR to address this
mtarking
requested changes
Dec 11, 2024
Comment on lines
+55
to
+56
| enable_nxapi: true | ||
| enable_nxapi_http: true |
There was a problem hiding this comment.
@mikewiebe can you (we) review these with respect to d2d that @rafmuller was looking at for device specific; i.e. if a device also has these like we talked maybe we enable fabric wide for dtc vs defining in model as such...thoughts???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
Test Notes
Cisco NDFC Version
Checklist