Merge pull request #129 from digitalocean/fix-127

Fixes IndexError when field is empty list.
netbox-community · Dec 8, 2018 · 6e6a802 · 6e6a802
2 parents 8d5d981 + a33ccd3
commit 6e6a802
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,10 @@
 
+v4.0.4 (2018-12-07)
+
+## Bug Fixes
+* Fixes IndexError introduced by fix for #127 when field is empty list.
+
+---
 v4.0.3 (2018-12-07)
 
 ## Bug Fixes

diff --git a/pynetbox/core/response.py b/pynetbox/core/response.py
@@ -183,8 +183,8 @@ def __iter__(self):
             cur_attr = getattr(self, i)
             if isinstance(cur_attr, Record):
                 yield i, dict(cur_attr)
-            elif isinstance(cur_attr, list) and isinstance(
-                cur_attr[0], Record
+            elif isinstance(cur_attr, list) and all(
+                isinstance(i, Record) for i in cur_attr
             ):
                 yield i, [dict(x) for x in cur_attr]
             else:

diff --git a/tests/unit/test_response.py b/tests/unit/test_response.py
@@ -99,6 +99,7 @@ def test_dict(self):
                 321,
                 231,
             ],
+            'empty_list': [],
             'record_list': [
                 {
                     'id': 123,
-Original file line number
+Diff line change
@@ Expand Up / @@ -99,6 +99,7 @@ def test_dict(self): @@
 ,
 ,
                 ],
+                'empty_list': [],
                 'record_list': [
                     {
                         'id': 123,
@@ Expand Down @@