Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA release workflow #33

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Add GHA release workflow #33

merged 8 commits into from
Aug 10, 2024

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Aug 9, 2024

No description provided.

Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz self-assigned this Aug 9, 2024
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz changed the title [DRAFT] add GHA release workflow (dry-run) Add GHA release workflow Aug 9, 2024
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz marked this pull request as ready for review August 9, 2024 19:38
@natm natm self-requested a review August 10, 2024 09:33
@natm
Copy link
Member

natm commented Aug 10, 2024

The plugin config version in __init__.py needs to be dynamic, follow the same pattern as the diode-netbox-plugin and have it sourced from an external version.py that is overwritten during the release process.

Examples:

@jeremystretch jeremystretch merged commit edce33f into develop Aug 10, 2024
3 checks passed
@jeremystretch jeremystretch deleted the gha-release-workflow branch August 10, 2024 19:43
@natm
Copy link
Member

natm commented Aug 12, 2024

The plugin config version in __init__.py needs to be dynamic, follow the same pattern as the diode-netbox-plugin and have it sourced from an external version.py that is overwritten during the release process.

Examples:

@mfiedorowicz please add this into a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants