Merge pull request #61 from netglade/fix/14.0.1

Dont check onSafe for check-is-not-closed-after-async-gap
netglade · Dec 10, 2024 · ab92823 · ab92823
2 parents 47abe51 + 33e5f48
commit ab92823
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/netglade_analysis/CHANGELOG.md b/packages/netglade_analysis/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 14.0.1
+- Don't check onSafe with check-is-not-closed-after-async-gap
+
 ## 14.0.0
 - Adhere to DCM 1.25.0:
   - Add avoid-single-field-destructuring

diff --git a/packages/netglade_analysis/lib/dcm.yaml b/packages/netglade_analysis/lib/dcm.yaml
@@ -460,9 +460,9 @@ dart_code_metrics:
     # - avoid-passing-bloc-to-bloc
     - avoid-passing-build-context-to-blocs
     - avoid-returning-value-from-cubit-methods
-    - check-is-not-closed-after-async-gap:
-        additional-methods:
-          - onSafe
+    - check-is-not-closed-after-async-gap
+        # additional-methods:
+          # - onSafe # ? Don't put onSafe here, it automatically checks whether bloc is closed in emit
     - emit-new-bloc-state-instances
     - handle-bloc-event-subclasses:
         additional-methods:

diff --git a/packages/netglade_analysis/pubspec.yaml b/packages/netglade_analysis/pubspec.yaml
@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 14.0.0
+version: 14.0.1
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
 issue_tracker: https://github.com/netglade/flutter_core/issues