Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analysis to 8 #27

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Update analysis to 8 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cfaeb7
Update analysis to 8
tenhobi Feb 16, 2024
6abe901
Fix lint
tenhobi Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/netglade_analysis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:

```yaml
dev_dependencies:
netglade_analysis: ^7.0.0
netglade_analysis: ^8.0.0
```

Then, add an include in `analysis_options.yaml`:
Expand Down
2 changes: 1 addition & 1 deletion packages/netglade_flutter_utils/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ environment:
dependencies:
flutter:
sdk: flutter
netglade_analysis: ^7.0.0
netglade_analysis: ^8.0.0
netglade_flutter_utils:
path: ..

Expand Down
2 changes: 1 addition & 1 deletion packages/netglade_flutter_utils/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dev_dependencies:
flutter_test:
sdk: flutter
mocktail: ^1.0.0
netglade_analysis: ^7.0.0
netglade_analysis: ^8.0.0
test: ^1.24.6

flutter:
Expand Down
18 changes: 9 additions & 9 deletions packages/netglade_flutter_utils/test/src/hooks/route_aware_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,6 @@ class _UnderTestWidget extends HookWidget {
required this.onAction,
});

void _handlePopBtnPressed(BuildContext context) {
Navigator.of(context).pop();
}

void _handlePushNextBtnPressed(BuildContext context) {
// ignore: avoid-undisposed-instances, ok for test
unawaited(Navigator.of(context).push(MaterialPageRoute<void>(builder: (_) => const _MockPage())));
}

@override
Widget build(BuildContext context) {
final state = useState<String>('??');
Expand Down Expand Up @@ -80,6 +71,15 @@ class _UnderTestWidget extends HookWidget {
],
);
}

void _handlePopBtnPressed(BuildContext context) {
Navigator.of(context).pop();
}

void _handlePushNextBtnPressed(BuildContext context) {
// ignore: avoid-undisposed-instances, ok for test
unawaited(Navigator.of(context).push(MaterialPageRoute<void>(builder: (_) => const _MockPage())));
}
}

void main() {
Expand Down
Loading