Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for firstLetterUppercase #49

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Fix for firstLetterUppercase #49

merged 2 commits into from
Aug 16, 2024

Conversation

TenViki
Copy link
Contributor

@TenViki TenViki commented Aug 15, 2024

This pull requests adds unit tests for the firstLetterUppercase method and fixes RangeError thrown when the string passed to this method is empty.

@TenViki TenViki requested a review from petrnymsa as a code owner August 15, 2024 14:51
Copy link
Member

@petrnymsa petrnymsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tenhobi tenhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tenhobi tenhobi merged commit a6f910c into netglade:main Aug 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants