Refactor specialised variants into subclasses #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenhobi
reviewed
Jan 26, 2025
| ), | ||
| ].indexed) { | ||
| test( | ||
| '(${testCase.$1}): ${testCase.$2.test} should be valid between ${testCase.$2.start} - ${testCase.$2.end} when testing inclusive and with included time', |
There was a problem hiding this comment.
nit: in for loop I would extract index and test case so we dont have to use $1 and $2 in here.
storybook/lib/debug_model.dart
Outdated
Comment on lines
41
to
51
| // ..satisfy( | ||
| // (value) { | ||
| // if (!vipInput.value) { | ||
| // return true; | ||
| // } | ||
|
|
||
| return value >= 18; | ||
| }, | ||
| devError: (_) => 'When VIP enabled you must be at least 18 years old.', | ||
| key: _ErrorKeys.ageRestriction, | ||
| )) | ||
| // return value >= 18; | ||
| // }, | ||
| // devError: (_) => 'When VIP enabled you must be at least 18 years old.', | ||
| // key: _ErrorKeys.ageRestriction, | ||
| // ) |
|
Also since we are doing breaking change, we can do these fixes from analysis options? avoid-commented-out-code: false # code examples in comments |
tenhobi
reviewed
Jan 26, 2025
| typedef DateTimeValidatorFactory = ValidatorInstance<DateTime> Function(DateTimeValidator validator); | ||
| typedef DateTimeValidatorFactoryNullable = ValidatorInstance<DateTime?> Function(DateTimeValidatorNullable validator); | ||
|
|
||
| class DateTimeValidator extends GladeValidator<DateTime> { |
There was a problem hiding this comment.
Add isBefore and isAfter, maybe also shorthand for isBeforeNow and isAfterNow?
DCM report✅ no issues found! Full report: https://github.com/netglade/glade_forms/runs/36366388403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.