feat(lookup): Add Zucchetti Infinity API in lookup sample scripts #374
+93
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
reviewed
Feb 13, 2025
| token_response = requests.post(token_url, auth=auth, data=token_body) | ||
| if token_response.status_code != 200: | ||
| raise Exception('Failed to get token from ' + token_url + ' with status code ' + str(token_response.status_code)) | ||
| token = token_response.json()['access_token'] |
There was a problem hiding this comment.
This is duplicated: already done on next line
Comment on lines
+82
to
+88
| if 'company' in contact and contact['company'] != '': | ||
| result["company"] = contact['company'] | ||
| if 'name' in contact and contact["name"] != '': | ||
| names.add(contact["name"]) | ||
| if len(names) == 1: | ||
| result["name"] = names.pop() | ||
|
|
There was a problem hiding this comment.
This is can be greatly simplified:
result["company"] = contact.get("company", "")
result["name"] = contact.get("name", "")
Since names.pop() returns a random element, it does not make sense at all.
There was a problem hiding this comment.
result["company"] = contact.get("company", "") is not the same because i don't wan't to overwrite a possible good result with an empty string
pop returns the only element (if len(names) == 1) if there are more than one is good that it remains empty because is the case that number have more contacts with different names, like if there is "Giacomo" and "Stefano" both with company "Nethesis" and same number, it returns {"company":"Nethesis" , "name":""}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NethServer/dev#7287