Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: untrack tsconfig.tsbuildinfo file (reduces NPM package size by 24%) #7005

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Jan 20, 2025

Summary

This file shouldn't be tracked in git, as it's meant for each developer machine's to keep state for incremental compilation speed.

This was also ending up in the published package, where it accounted for ~24% of the tarball (320 out of 1330 KB), as reported by npx pkg-size.

Note that this does not address this package's bloat due to its dependencies. That's a whole other rabbit hole.

This shouldn't be tracked in git, as it's meant for each developer machine's to keep state
for incremental compilation speed.

This was also ending up in the published package, where it accounted for ~24% of the
tarball (320 out of 1330 KB).
@serhalp serhalp requested a review from a team as a code owner January 20, 2025 20:12
Copy link

📊 Benchmark results

Comparing with 4631558

  • Dependency count: 1,201 (no change)
  • Package size: 316 MB ⬆️ 0.00% increase vs. 4631558
  • Number of ts-expect-error directives: 830 (no change)

@serhalp serhalp merged commit badfe15 into main Jan 21, 2025
49 checks passed
@serhalp serhalp deleted the fix/reduce-pkg-size branch January 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants