Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & fix Testmo actions/logic #230

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

dbarbuzzi
Copy link
Contributor

This PR updates and fixes Testmo actions/usage logic:

  • All Testmo actions are updated to the latest version (which, among other things, eliminates the need to install the CLI tool separately)
  • Fixes a "bug" in the conditional logic so that it is properly evaluated (it seems that GitHub doesn’t like mixing functions / expressions in and out of the double-curly braces in these places)

Here is a re-run of the upload workflow that failed on main (due to a Testmo step not being correctly skipped and thus failing): https://github.com/neuralmagic/compressed-tensors/actions/runs/12468376137/job/34799436033

@dbarbuzzi dbarbuzzi requested a review from dhuangnm December 23, 2024 14:32
@dbarbuzzi dbarbuzzi self-assigned this Dec 23, 2024
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@dbarbuzzi dbarbuzzi requested a review from kylesayrs December 23, 2024 14:44
Copy link
Member

@dhuangnm dhuangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dbarbuzzi dbarbuzzi merged commit fe4a442 into main Dec 23, 2024
1 check passed
@dbarbuzzi dbarbuzzi deleted the update-fix-testmo-actions branch December 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants