Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Transformers Unit Tests on PRs #1839

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Run Transformers Unit Tests on PRs #1839

merged 3 commits into from
Nov 20, 2023

Conversation

Satrat
Copy link

@Satrat Satrat commented Nov 16, 2023

The unit tests in tests/sparseml/transformers were not being run on PRs. Updating the GHA workflow to trigger these tests under a new test-transformers action

dbogunowicz
dbogunowicz approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it looks like your PR works (the tests are probably failing for good reason haha). If you want me to help you fixing them, just tell me.

@Satrat Satrat requested review from bfineran and dsikka November 20, 2023 15:33
@bfineran bfineran merged commit eb1cc87 into main Nov 20, 2023
11 of 12 checks passed
@bfineran bfineran deleted the transformers_gha branch November 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@bfineran bfineran bfineran approved these changes

@dsikka dsikka Awaiting requested review from dsikka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satrat @bfineran @dbogunowicz @mgoin