Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows for dev, nightly, and release Docker containers #2153

Merged
merged 17 commits into from
Mar 25, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Mar 4, 2024

Summary

1. Dev

  • For dev, a container is created if a PR to main is opened or updated
  • sparseml will be cloned using the specific branch and an editable install will be used to install all packages
  • The container will be tagged with the PR number when pushed to GCR

2. Release

  • When a PR is opened/updated to a release branch: in that case, sparseml will be installed using the specific version of the release

3. Nightly

  • When a PR is merged into main, sparseml will install the latest nightly build
  • A scheduled nightly cron job will trigger a nightly build and create a container with the most recent nightly build

Testing

  • Nightly and dev workflows have been tested and containers are currently being pushed to packages
  • Release builds have not been tested

Next Steps:

  • Update the names of the containers in GCR. So far using dummy test names but will need slight updating to consider the different workflows
  • Find a non-destructive way to test release workflows

@dsikka dsikka marked this pull request as ready for review March 5, 2024 15:52
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
docker/containers/docker_dev/Dockerfile Outdated Show resolved Hide resolved
docker/containers/docker_dev/Dockerfile Outdated Show resolved Hide resolved
docker/containers/docker_dev/Dockerfile Outdated Show resolved Hide resolved
@dsikka dsikka requested a review from horheynm March 14, 2024 15:46
@dsikka dsikka force-pushed the docker_builds branch 2 times, most recently from be9fd83 to ed5fe6d Compare March 19, 2024 20:51
@dsikka
Copy link
Contributor Author

dsikka commented Mar 20, 2024

FYI - we need to use self-hosted runners for the dev containers. This requires further protections as our repo is public. The Build Docker Container workflow will fail until this workflow is enabled as we need more than 25GB of disk space.

@bfineran bfineran merged commit 1a30e04 into main Mar 25, 2024
12 of 15 checks passed
@bfineran bfineran deleted the docker_builds branch March 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants