-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparseML Compression Pt 1: saving w/compression configs #2177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nitpicks. All in all great job, definitely well done on a bite-sized scope of this PR
src/sparseml/transformers/compression/compressors/sparse_bitmask.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Sara, this looks good to me for saving. Just some comments on state dict conflicts and tensor devices
src/sparseml/transformers/compression/compressors/sparse_bitmask.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎅
Co-authored-by: dbogunowicz <[email protected]>
This initial PR for safetensors compression sets up the
CompressionConfig
andModelCompressor
registries and implements bitmask compression on save. See the corresponding internal docs PR for design detailsTo be implemented in follow-up PRs
Example