Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Bumped cd workflow node-version to 18 #581

Merged
merged 2 commits into from
Oct 25, 2023
Merged

[CI] Bumped cd workflow node-version to 18 #581

merged 2 commits into from
Oct 25, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 23, 2023 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 02a85f8
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/653958f846b7e200076895e5
😎 Deploy Preview https://deploy-preview-581--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review October 24, 2023 20:28
surchs
surchs approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🧑‍🍳

If it's green after merging master into this PR, go ahead and squash into master

@rmanaem rmanaem merged commit ea82ec2 into master Oct 25, 2023
@rmanaem rmanaem deleted the cd-workflow-fix branch October 25, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmanaem @surchs