Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Impemented validation for output JSON #602

Merged
merged 21 commits into from
Nov 3, 2023
Merged

[ENH] Impemented validation for output JSON #602

merged 21 commits into from
Nov 3, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 2, 2023 •
edited by surchs
Loading

Closes #597

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit a8b8bc4
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/65453a7b947388000899a520
😎 Deploy Preview https://deploy-preview-602--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs
Copy link
Contributor

surchs commented Nov 2, 2023 •
edited
Loading

@rmanaem I think one reason the id selectors were so brittle might have to do that you ran the e2e locally off of npm runn dev but on the CI they are running off of the generated app (I believe).

edit: this is just another reminder to keep local dev as close as possible to what's actually running

@surchs @rmanaem
[FIX] test to use explicit file loading
235cb35 
Previously we relied on a files position in the list of downloaded files.
That's brittle. If we look for the correct file instead, it's not brittle.
Not brittle is better.

Co-authored-by: Arman Jahanpour <[email protected]>
surchs
surchs approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳 with the fixes to the download page test

when you merge, make sure that these two changes appear on the top of the itemized changes in the PR description.

cypress/fixtures/examples/good/example_synthetic copy_annotated_1698938921939.json Outdated Show resolved Hide resolved
@alyssadai
Copy link
Contributor

alyssadai commented Nov 3, 2023 •
edited
Loading

@rmanaem please also update the label for the "other" sex to read "Indeterminate sex" instead, to match the actual SNOMED term. 🙂

EDIT: Not planned anymore

@rmanaem
Copy link
Contributor Author

rmanaem commented Nov 3, 2023

I think one reason the id selectors were so brittle might have to do that you ran the e2e locally off of npm runn dev but on the CI they are running off of the generated app (I believe).

@surchs I see, so you think the generated IDs would be different when app is started using npm run generate as opposed to npm run dev. That would explain the discrepancies.

@rmanaem rmanaem merged commit 6ae714a into master Nov 3, 2023
7 checks passed
@rmanaem rmanaem deleted the feat-597 branch November 3, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure we create valid .json
3 participants
@rmanaem @surchs @alyssadai