Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implemented styling for table rows of annot-single-tool component #655

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Dec 9, 2023

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit e0862c1
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/657c7d613128e7000885faba
😎 Deploy Preview https://deploy-preview-655--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem requested a review from surchs December 14, 2023 21:18
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice PR, thanks @rmanaem!

I left one suggestion for clarity there. One other thing I noticed is that if we ever decide to enable table sorting, we probably have to rethink this. We'll probably figure this out then, but you could also add a TODO comment as a reminder.

🧑‍🍳

components/annot-single-tool.vue Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Urchs <[email protected]>
@rmanaem rmanaem merged commit 826a2a9 into main Dec 15, 2023
8 checks passed
@rmanaem rmanaem deleted the feat-620 branch December 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaner visual interface for assessment tool missing value annotation
2 participants