Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add help text for built-in datatable filtering syntax and show column datatypes #128

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

alyssadai
Copy link
Collaborator

@alyssadai alyssadai commented Jan 16, 2024

Changes proposed in this pull request:

  • Add collapsible help text for datatable filtering syntax, including filtering for missing values
  • Switch to not using dcc.Markdown where possible to avoid un-adjustable extra bottom padding
  • Set column type explicitly in datatable based on pandas dtype, and display in phenotypic column summary (allows users to have an easier time choosing the right filtering operators)

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR @alyssadai 🎉! With the amount of custom callbacks and style handling you're doing, you'll feel right at home in the frontend once you'll join us there.

I left one comment to add a disclaimer that a "is not blank" filter does not (seem) to exist - because that's the first thing I tried after learning about "is blank".

🧑‍🍳

digest/app.py Show resolved Hide resolved
digest/layout.py Outdated Show resolved Hide resolved
digest/layout.py Show resolved Hide resolved
@alyssadai alyssadai merged commit 82ebfdd into main Jan 17, 2024
2 checks passed
@alyssadai alyssadai deleted the enable-missing-value-filtering branch January 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants