Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Correctly embed tailwind into the site #199

Merged
merged 1 commit into from
May 14, 2024
Merged

[ENH] Correctly embed tailwind into the site #199

merged 1 commit into from
May 14, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented May 14, 2024 •
edited by rmanaem
Loading

Get rid of CDN dependency

Changes proposed in this pull request:

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

@surchs
[ENH] Correctly embed tailwind into the site
54dad58 
Get rid of CDN dependency
Closes #55
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 54dad58
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6643afd98e3b650008d59172
😎 Deploy Preview https://deploy-preview-199--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem self-requested a review May 14, 2024 20:18
rmanaem
rmanaem approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs merged commit c05afaa into main May 14, 2024
6 of 7 checks passed
@surchs surchs deleted the iss55 branch May 14, 2024 21:25
@surchs surchs mentioned this pull request May 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace tailwind CDN with proper minification
2 participants
@surchs @rmanaem