Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the NTIDIGITS18 dataset #297

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

narduzzi
Copy link
Contributor

No description provided.

@narduzzi narduzzi requested a review from biphasic December 18, 2024 15:45
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.75000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (a4e8a45) to head (50a80d3).
Report is 85 commits behind head on develop.

Files with missing lines Patch % Lines
tonic/datasets/ntidigits18.py 68.25% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
+ Coverage    77.07%   77.32%   +0.25%     
===========================================
  Files           54       56       +2     
  Lines         3067     3295     +228     
===========================================
+ Hits          2364     2548     +184     
- Misses         703      747      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narduzzi
Copy link
Contributor Author

Should the download from Dropbox be integrated in 'download_utils.py' instead of being local to this class?

@biphasic
Copy link
Member

biphasic commented Jan 7, 2025

@narduzzi that looks very good! will merge right away

@biphasic biphasic merged commit fa4fdfb into neuromorphs:develop Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants