[NTRN-192] feat: add proto build #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotnikov-s
force-pushed
the
feat/add-proto-build
branch
from
150a9b1 to
6ff4684
Compare
sotnikov-s
force-pushed
the
feat/add-proto-build
branch
from
75452f9 to
ed3547b
Compare
sotnikov-s
force-pushed
the
feat/add-proto-build
branch
from
12f4d87 to
19efb7a
Compare
…o feat/add-proto-build
pr0n00gler
reviewed
Mar 14, 2024
neutron
Outdated
There was a problem hiding this comment.
Hm, is it required to be here?
There was a problem hiding this comment.
Maybe we can avoid using submodules and just clone the repo and then remove it after all proto generations?
pr0n00gler
reviewed
Mar 14, 2024
README.md
Outdated
| proto files have changed there's a command for Rust generated code rebuild. To rebuild the files, | ||
| run the following command using the respective Neutron revision (commit hash) as an argument, e.g.: | ||
| ```sh | ||
| make build-proto revision=60b7d38358efb2f8e45e25ee4db8e19a6462dd9e |
There was a problem hiding this comment.
Btw make build-proto revision=v2.0.3 (tags) also works, so maybe it's worth to simplify readme example with a tag, not a commit
There was a problem hiding this comment.
Cause in normal circumstances we should use tags anyway, not just a random commit
pr0n00gler
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://hadronlabs.atlassian.net/browse/NTRN-192
This PR:
proto-buildscript'smod.rspopulation partmake build-protocommandproto-types) version to the current Neutron v3.0.3